Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the logic for determining downstream version status #4987

Conversation

sgalsaleh
Copy link
Member

@sgalsaleh sgalsaleh commented Nov 5, 2024

What this PR does / why we need it:

Consolidate the logic for determining downstream version status so it's easier to unit test and more readable.

Which issue(s) this PR fixes:

SC-106273

Does this PR require a test?

Yes

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

@sgalsaleh sgalsaleh added the type::feature New feature or request label Nov 5, 2024
@sgalsaleh sgalsaleh marked this pull request as ready for review November 6, 2024 18:13
@sgalsaleh sgalsaleh requested a review from laverya November 6, 2024 18:13
@sgalsaleh sgalsaleh merged commit 239b0e5 into main Nov 6, 2024
122 checks passed
@sgalsaleh sgalsaleh deleted the laverya/sc-106273/pass-config-values-to-embedded-cluster-during branch November 6, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants