Fix 404 in Admin Console #4980
Merged
Fix 404 in Admin Console #4980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename route from /insecure -> /tls-warning
miaawong
force-pushed
the
miawong/sc-115316/fix-404-insecure-page-in-admin-console
branch
from
a68cfb5 to
7616a96
Compare
sgalsaleh
approved these changes
Nov 1, 2024
miaawong
deleted the
miawong/sc-115316/fix-404-insecure-page-in-admin-console
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/insecure route was not defined in #4951
This PR renames the route from /insecure -> /tls-warning
and defines a route for it
What this PR does / why we need it:
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/115316/fix-404-insecure-page-in-admin-console
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?