Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persist http proxy settings and security context on upgrades #4962

Merged

Conversation

emosbaugh
Copy link
Member

@emosbaugh emosbaugh commented Oct 22, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?

- Fixes an issue that causes proxy settings to be removed on `kotsadm admin-console upgrade`.
- Fixes an issue that causes `--strict-security-context` to be removed on `kotsadm admin-console upgrade`.

Does this PR require documentation?

@emosbaugh emosbaugh added type::bug Something isn't working bug::normal labels Oct 22, 2024
@emosbaugh emosbaugh force-pushed the emosbaugh/sc-114437/kots-install-settings-not-persisted-when branch 2 times, most recently from 779e011 to 8655673 Compare October 22, 2024 18:30
@emosbaugh emosbaugh force-pushed the emosbaugh/sc-114437/kots-install-settings-not-persisted-when branch from 8655673 to 1993158 Compare October 22, 2024 18:32
@emosbaugh emosbaugh marked this pull request as ready for review October 22, 2024 21:19
@emosbaugh
Copy link
Member Author

The failing test seems to be from docker rate limiting. Merging through the failure

Screenshot 2024-10-22 at 2 19 07 PM

@emosbaugh emosbaugh merged commit 28122a9 into main Oct 22, 2024
154 of 156 checks passed
@emosbaugh emosbaugh deleted the emosbaugh/sc-114437/kots-install-settings-not-persisted-when branch October 22, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants