Use cluster role for the SDK deployment when running in EC #4952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
force-pushed
the
divolgin/sc-114128/replicated-sdk-reports-k0s-when-installed
branch
from
643f35d to
cce70fd
Compare
sgalsaleh
reviewed
Oct 15, 2024
divolgin
force-pushed
the
divolgin/sc-114128/replicated-sdk-reports-k0s-when-installed
branch
from
cce70fd to
5f9ee0b
Compare
divolgin
force-pushed
the
divolgin/sc-114128/replicated-sdk-reports-k0s-when-installed
branch
from
5f9ee0b to
30446b3
Compare
laverya
approved these changes
Oct 17, 2024
divolgin
deleted the
divolgin/sc-114128/replicated-sdk-reports-k0s-when-installed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In EC installs, Replicated SDK is not being granted cluster level access, which limits its functionality resulting in bad data being reported.
Relevant Replicated SDK PR: replicatedhq/replicated-sdk#218
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/114128/replicated-sdk-reports-k0s-when-installed-in-embedded-cluster-causing-distribution-to-flip-flop-in-events-view
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?