Move multi app install test to Playwright #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandemicsyn
reviewed
Sep 24, 2024
There was a problem hiding this comment.
@sgalsaleh I think maybe the test got skipped during the action run, but not immediately obvious to me why.
just saw the update.
Comment on lines
+120
to
+121
| AppSlug: "mutli-app-install", | ||
| UpstreamURI: "mutli-app-install/automated", |
There was a problem hiding this comment.
Suggested change
| AppSlug: "mutli-app-install", | |
| UpstreamURI: "mutli-app-install/automated", | |
| AppSlug: "multi-app-install", | |
| UpstreamURI: "multi-app-install/automated", |
There was a problem hiding this comment.
@sgalsaleh this looks like a typo - but i see the license and playwright tests are looking for mutli as well so not positive.
There was a problem hiding this comment.
yeah, it's a typo in the app slug, but this matches so it should work...
pandemicsyn
approved these changes
Sep 24, 2024
miaawong
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Move multi app install test to Playwright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-112705