return the entire installation spec object in a EC join struct #4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
previously approved these changes
Sep 20, 2024
emosbaugh
reviewed
Sep 20, 2024
| K0sToken string `json:"k0sToken"` | ||
| EmbeddedClusterVersion string `json:"embeddedClusterVersion"` | ||
| AirgapRegistryAddress string `json:"airgapRegistryAddress"` | ||
| Spec ecv1beta1.InstallationSpec `json:"installationSpec,omitempty"` |
There was a problem hiding this comment.
why not call it InstallationSpec
There was a problem hiding this comment.
I mean sure
it doesn't change anything, it's already encoded as 'installationSpec' 😆
emosbaugh
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This way new fields will be returned automatically as we add them.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?