Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read PROXY env in more places when deploying #4891

Merged

Conversation

divolgin
Copy link
Member

@divolgin divolgin commented Sep 13, 2024

What this PR does / why we need it:

When running automated install, PROXY env variables not used.

divolgin@dmitriy-kots-001:~$ export HTTP_PROXY=http://10.128.0.23:3128
divolgin@dmitriy-kots-001:~$ export HTTPS_PROXY=http://10.128.0.23:3128
divolgin@dmitriy-kots-001:~$ export NO_PROXY=.cluster.local,10.0.0.0/8,10.96.0.1,35.225.92.50,kotsadm-rqlite,kotsadm-postgres,kotsadm-minio,kotsadm-api-node
divolgin@dmitriy-kots-001:~$ ./kots install dmitriykots2/beta --copy-proxy-env=true --license-file dmitriy-kots-3-new\ \(2\).yaml --config-values config.yaml --shared-password password --namespace dmitriykots2 --skip-preflights 
  • Checking for license update ✓  
  • Deploying Admin Console
    • Creating namespace ✓  
    • Waiting for datastore to be ready ✓  
  • Waiting for Admin Console to be ready ✓  
  • Waiting for installation to complete ✓  
$ kubectl -n dmitriykots2 describe deployment replicated | grep Environment -A 10
    Environment:
      HTTP_PROXY:                    http://10.128.0.23:3128
      HTTPS_PROXY:                   http://10.128.0.23:3128
      NO_PROXY:                      .cluster.local,10.0.0.0/8,10.96.0.1,35.225.92.50,kotsadm-rqlite,kotsadm-postgres,kotsadm-minio,kotsadm-api-node,kotsadm-rqlite,kotsadm-postgres,kotsadm-minio,kotsadm-api-node
      REPLICATED_NAMESPACE:           (v1:metadata.namespace)
      REPLICATED_POD_NAME:            (v1:metadata.name)
      DISABLE_OUTBOUND_CONNECTIONS:  false
      IS_HELM_MANAGED:               true
      HELM_RELEASE_NAME:             replicated
      HELM_RELEASE_NAMESPACE:        dmitriykots2
      HELM_PARENT_CHART_URL:         

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/111175/support-for-installing-behind-a-proxy#activity-112112

Does this PR require a test?

Does this PR require a release note?

Fixes an issue where the values provided to the --http-proxy, --https-proxy, and --no-proxy flags for the kots install command were not propagated to the Replicated SDK when running an automated install.

Does this PR require documentation?

@divolgin divolgin added the type::feature New feature or request label Sep 13, 2024
@divolgin divolgin marked this pull request as ready for review September 14, 2024 00:14
@divolgin divolgin merged commit af9100c into main Sep 16, 2024
117 checks passed
@divolgin divolgin deleted the divolgin/sc-111175/support-for-installing-behind-a-proxy branch September 16, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants