Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass-through PROXY environment to Replicated SDK deployment #4862

Merged

Conversation

divolgin
Copy link
Member

@divolgin divolgin commented Sep 4, 2024

What this PR does / why we need it:

When kotsadm is configured to use proxy at install time, Replicated SDK chart must also be configured with the same proxy settings.

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/111175/support-for-installing-behind-a-proxy

Does this PR require a test?

Unit tests updates. The change manually tested with a real proxy:

$ kubectl -n dmitriykots2 describe deployment replicated | grep Environment -A 10
    Environment:
      HTTP_PROXY:                    http://10.128.0.23:3128
      HTTPS_PROXY:                   http://10.128.0.23:3128
      NO_PROXY:                      10.96.0.1,35.225.92.50,kotsadm-rqlite,kotsadm-postgres,kotsadm-minio,kotsadm-api-node
      REPLICATED_NAMESPACE:           (v1:metadata.namespace)
      REPLICATED_POD_NAME:            (v1:metadata.name)
      DISABLE_OUTBOUND_CONNECTIONS:  false
      IS_HELM_MANAGED:               true
      HELM_RELEASE_NAME:             replicated
      HELM_RELEASE_NAMESPACE:        dmitriykots2
      HELM_PARENT_CHART_URL:         

Does this PR require a release note?

- When `--http-proxy`, `--https-proxy`, and `--no-proxy` flags are used with `kots install` command, the same values will be configured in the `replicated` deployment.

Does this PR require documentation?

@divolgin divolgin added the type::feature New feature or request label Sep 4, 2024
@divolgin divolgin force-pushed the divolgin/sc-111175/support-for-installing-behind-a-proxy branch from 1fc54f8 to aeb5b0c Compare September 4, 2024 22:55
@divolgin divolgin force-pushed the divolgin/sc-111175/support-for-installing-behind-a-proxy branch from 5901ad9 to 4d3503a Compare September 4, 2024 23:00
@divolgin divolgin marked this pull request as ready for review September 4, 2024 23:27
@divolgin divolgin merged commit 373a414 into main Sep 4, 2024
111 checks passed
@divolgin divolgin deleted the divolgin/sc-111175/support-for-installing-behind-a-proxy branch September 4, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants