-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec): ability to upgrade the cluster #4678
feat(ec): ability to upgrade the cluster #4678
Conversation
46b72f6
to
474fb43
Compare
pkg/embeddedcluster/upgrade.go
Outdated
CheckRedirect: func(req *http.Request, via []*http.Request) error { | ||
if strings.Contains(req.URL.Path, "/embedded-cluster-public-files/") { | ||
// Workaround as cloudflare complains about unsupported auth method | ||
req.Header.Del("Authorization") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's probably good practice to always remove the auth header on redirect. idk why Go doesn't do that automatically. can probably just always delete the auth header without checking the path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im fixing this in the proxy https://github.com/replicatedhq/cloudflare-workers/pull/348
pkg/embeddedcluster/upgrade.go
Outdated
} | ||
|
||
func embeddedRegistryImageAddress(registryDomain string, srcImage string) (string, error) { | ||
imagePath, err := image.PathToRegistryECImage(srcImage, registryDomain) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the second parameter is the registry namespace, not the domain. these registry settings should be passed by the deploy function from kots.
* airgap preflight reporting for upgrade service * create SubmitAppInfo func for upgrade service * use UpgradeServiceParams where possible
* ability to deploy an available update
* Airgap upgrade service --------- Co-authored-by: Craig O'Donnell <[email protected]>
b80bf40
to
5aef836
Compare
* temporarily disable EKS 1.30 testing * Pin ARC charts versions (cherry picked from commit 20853b8) --------- Co-authored-by: Salah Al Saleh <[email protected]>
* Bump github.com/replicatedhq/troubleshoot from 0.92.2 to 0.93.2 Bumps [github.com/replicatedhq/troubleshoot](https://github.com/replicatedhq/troubleshoot) from 0.92.2 to 0.93.2. - [Release notes](https://github.com/replicatedhq/troubleshoot/releases) - [Commits](replicatedhq/troubleshoot@v0.92.2...v0.93.2) --- updated-dependencies: - dependency-name: github.com/replicatedhq/troubleshoot dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * go mod tidy * fix --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Salah Al Saleh <[email protected]>
Bumps the security group with 2 updates: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) and [github.com/schemahero/schemahero](https://github.com/schemahero/schemahero). Updates `github.com/aws/aws-sdk-go` from 1.54.2 to 1.54.6 - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.54.2...v1.54.6) Updates `github.com/schemahero/schemahero` from 0.17.8 to 0.17.9 - [Release notes](https://github.com/schemahero/schemahero/releases) - [Commits](schemahero/schemahero@v0.17.8...v0.17.9) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: security - dependency-name: github.com/schemahero/schemahero dependency-type: direct:production update-type: version-update:semver-patch dependency-group: security ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Salah Al Saleh <[email protected]>
Bumps the security group in /web with 6 updates: | Package | From | To | | --- | --- | --- | | [monaco-editor](https://github.com/microsoft/monaco-editor) | `0.49.0` | `0.50.0` | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `20.14.2` | `20.14.7` | | [eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y) | `6.8.0` | `6.9.0` | | [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) | `7.34.2` | `7.34.3` | | [sass](https://github.com/sass/dart-sass) | `1.77.5` | `1.77.6` | | [webpack](https://github.com/webpack/webpack) | `5.92.0` | `5.92.1` | Updates `monaco-editor` from 0.49.0 to 0.50.0 - [Release notes](https://github.com/microsoft/monaco-editor/releases) - [Changelog](https://github.com/microsoft/monaco-editor/blob/main/CHANGELOG.md) - [Commits](microsoft/monaco-editor@v0.49.0...v0.50.0) Updates `@types/node` from 20.14.2 to 20.14.7 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `eslint-plugin-jsx-a11y` from 6.8.0 to 6.9.0 - [Release notes](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-jsx-a11y@v6.8.0...v6.9.0) Updates `eslint-plugin-react` from 7.34.2 to 7.34.3 - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.34.2...v7.34.3) Updates `sass` from 1.77.5 to 1.77.6 - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.77.5...1.77.6) Updates `webpack` from 5.92.0 to 5.92.1 - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.92.0...v5.92.1) --- updated-dependencies: - dependency-name: monaco-editor dependency-type: direct:production update-type: version-update:semver-minor dependency-group: security - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: security - dependency-name: eslint-plugin-jsx-a11y dependency-type: direct:development update-type: version-update:semver-minor dependency-group: security - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-patch dependency-group: security - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch dependency-group: security - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-patch dependency-group: security ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Salah Al Saleh <[email protected]>
Co-authored-by: dydx <[email protected]>
5aef836
to
04776d0
Compare
What this PR does / why we need it:
Related replicatedhq/embedded-cluster-operator#218
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?