fix config and view files tab underlines #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodonnell
force-pushed
the
cbo/sc-102653/fix-subnav-underlines
branch
from
bab4053 to
361b9e8
Compare
cbodonnell
commented
May 13, 2024
| @@ -1,4 +1,5 @@ | |||
| name: Generate kURL Add-On | |||
| description: Generate kURL Add-On | |||
There was a problem hiding this comment.
actionlint started failing because these were missing https://github.com/replicatedhq/kots/actions/runs/9069742713/job/24919992210
cbodonnell
commented
May 13, 2024
| @@ -49,6 +49,7 @@ runs: | |||
|
|
|||
| - uses: chainguard-images/actions/apko-publish@main | |||
| with: | |||
| apko-image: ghcr.io/wolfi-dev/apko@sha256:87b47283433066d19b71e1cb4401be8d04b7d51f4f4263fde1977c3043b9754f | |||
There was a problem hiding this comment.
resolves issue with latest apko image https://github.com/replicatedhq/kots/actions/runs/9069367744/job/24919025968?pr=4616#step:3:140
sgalsaleh
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes an issue where the KOTS UI subnav would not show the selected tab for the "Config", "Troubleshoot", and "View Files" tabs. This is because previously we were only considering the last element in the path, so any routes with subpaths like
/config/<sequence>or/troubleshoot/analyze/<bundle-id>would cause the tabs to show as not active.Before
/app/craig-helm/tree/0:After
/app/craig-helm/tree/0:Which issue(s) this PR fixes:
Fixes https://app.shortcut.com/replicated/story/102653/config-and-view-files-tab-lack-blue-underline-when-clicked-on
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?