Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide navbar options on initial embedded install #4469

Merged
merged 5 commits into from
Feb 27, 2024
Merged

hide navbar options on initial embedded install #4469

merged 5 commits into from
Feb 27, 2024

Conversation

cbodonnell
Copy link
Contributor

@cbodonnell cbodonnell commented Feb 23, 2024 •
edited
Loading

What this PR does / why we need it:

This PR hides the navbar options for embedded clusters during the initial install flow. The main change is the introduction and usage of the isInitialAppInstall utility function that determines if a application is in its initial install phase based on current and pending downstream versions and their statuses.

Before:

Screenshot 2024-02-27 at 12 54 55 PM

After:

Screenshot 2024-02-27 at 12 56 05 PM

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/99650/remove-application-and-cluster-management-tabs-at-the-top-when-doing-an-initial-installation

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Hides the Application and Cluster Management tabs on the navbar during the initial install flow on [Embedded Clusters (Beta)](/vendor/embedded-overview).

Does this PR require documentation?

@cbodonnell cbodonnell marked this pull request as ready for review February 27, 2024 15:57
@cbodonnell cbodonnell requested a review from sgalsaleh February 27, 2024 17:59
@cbodonnell cbodonnell requested a review from sgalsaleh February 27, 2024 19:18
@cbodonnell cbodonnell merged commit d3b1426 into main Feb 27, 2024
104 checks passed
@cbodonnell cbodonnell deleted the cbo/hide-navbar-on-embedded-install branch February 27, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgalsaleh sgalsaleh sgalsaleh approved these changes

Assignees
No one assigned
Labels
type::feature New feature or request type::improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbodonnell @sgalsaleh