Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hidden ignore preflights option #4467

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

cbodonnell
Copy link
Contributor

What this PR does / why we need it:

This PR fixes an issue where the "Ignore Preflights" option was not displayed on the preflights page when preflights were running.

Fixes and would now be covered by this currently failing test https://app.testim.io/#/project/wpYAooUimFDgQxY73r17/branch/master/test/Ecw4Nb9QY7E0tlH0/step/xRHXDdEr5gRnFZqH/viewer/screenshots?result-id=fCnAxLtz2T3at7go&path=EINjRokMifGuEcuL%3AuAlu2UmjAzgrxA3n%3AxRHXDdEr5gRnFZqH

Before:

Screenshot 2024-02-23 at 12 22 01 PM

After:

Screenshot 2024-02-23 at 12 19 52 PM

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Fixes an issue where the "Ignore Preflights" option was not displayed on the preflights page when preflights were running.

Does this PR require documentation?

NONE

@cbodonnell cbodonnell added type::bug Something isn't working bug::normal labels Feb 23, 2024
@cbodonnell cbodonnell requested a review from sgalsaleh February 23, 2024 17:33
@cbodonnell cbodonnell merged commit 88926fb into main Feb 23, 2024
104 checks passed
@cbodonnell cbodonnell deleted the cbo/fix-ignore-preflights branch February 23, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants