Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show intermediate cluster upgrade status #4432

Merged
merged 1 commit into from
Feb 7, 2024
Merged

show intermediate cluster upgrade status #4432

merged 1 commit into from
Feb 7, 2024

Conversation

cbodonnell
Copy link
Contributor

What this PR does / why we need it:

This PR makes a few changes to create a smoother cluster upgrade experience:

  • The embedded cluster will now only be upgraded once the application is deployed and ready. Previously the cluster upgrade would happen whether or not the deployment was successful or app was ready.
  • The intermediate status of the cluster upgrade will be displayed in the UI ("waiting for app to be ready" and "updating cluster" messages).
  • Logic was added to the frontend to suppress error messages that might show during a cluster upgrade. This is because the UI will lose connectivity to the API during the upgrade, which is expected.

Loom: https://www.loom.com/share/bed22e2cfce34f3aa32ce3b915f44bec?sid=70f622dc-f7c9-4860-a781-70c5718ec6ce

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/97396/integrate-cluster-status-into-admin-console-and-app-deployment-status

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Does this PR require documentation?

NONE

@cbodonnell cbodonnell added type::feature New feature or request type::improvement labels Feb 6, 2024
@cbodonnell cbodonnell force-pushed the cbo/sc-97396/deploy-cluster-after-application branch from 1c74f0c to d9cb26b Compare February 6, 2024 21:39
@cbodonnell cbodonnell marked this pull request as ready for review February 7, 2024 14:37
@cbodonnell cbodonnell force-pushed the cbo/sc-97396/deploy-cluster-after-application branch from d9cb26b to f406415 Compare February 7, 2024 14:38
@cbodonnell cbodonnell merged commit a7b13fe into main Feb 7, 2024
104 checks passed
@cbodonnell cbodonnell deleted the cbo/sc-97396/deploy-cluster-after-application branch February 7, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgalsaleh sgalsaleh sgalsaleh approved these changes

Assignees
No one assigned
Labels
type::feature New feature or request type::improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbodonnell @sgalsaleh