embedded cluster upgrade modal #4398
Conversation
| // version is different from the currently deployed embedded cluster config | ||
| RequiresUpgrade bool `json:"requiresUpgrade"` | ||
| // State represents the current state of the most recently deployed embedded cluster config | ||
| State string `json:"state,omitempty"` |
There was a problem hiding this comment.
is there a more appropriate place for these response fields? cluster seems like an OK spot, but i know it's not necessarily meant to be for the "embedded cluster" but rather the "kots downstream cluster"
|
@alicenstar tagging you on this PR to see if there's anything on the front-end that you may have feedback on. |
|
@cbodonnell Would you be able to take a Loom showing the full functionality (what the connection error looks like and how the modal pops up)? I am reviewing the front end code now, but it would be easier if I could also see how it functions in the browser. |
@alicenstar Added a loom to the PR description. The new modal is meant to be shown in place of this existing modal, which is displayed when the UI loses connectivity to the API. We instead want to show a nicer message since this downtime is expected during an embedded cluster upgrade. 
|
|
@cbodonnell Thank you, that context is helpful! I'm in refinement right now so my review got a bit paused, but it should be over shortly. I do see an interesting pattern in |
What this PR does / why we need it:
This PR improves the KOTS UI so that when it loses connection to the API during a cluster upgrade, a separate dialog is shown indicating to the user that the cluster is being updated and that connectivity will be restored once it completes.
https://www.loom.com/share/29a2622f3cec4276aac30b5670dfc35a?sid=b0460ba2-26c5-4cf1-8ed5-dce842a7563f
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/97393/detect-cluster-update-and-show-a-better-message-when-the-admin-console-goes-down
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?