Arm64 support for KOTS images #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
force-pushed
the
arm64-support-for-kots
branch
from
71edbb3 to
03d9b3d
Compare
divolgin
reviewed
Jan 29, 2024
| @@ -521,7 +518,7 @@ func (c *Client) uninstallWithHelm(v1Beta1ChartsDir, v1Beta2ChartsDir string, ko | |||
| } | |||
|
|
|||
| logger.Infof("running helm with arguments %v", args) | |||
| cmd := exec.Command(fmt.Sprintf("helm%s", version), args...) | |||
There was a problem hiding this comment.
is this because v3 is the default and you just want to use the default?
There was a problem hiding this comment.
it's because we removed the helm 2 binary a long time ago but didn't refactor this code.
divolgin
reviewed
Jan 29, 2024
| @@ -281,3 +281,27 @@ func KustomizeImage(destRegistry registrytypes.RegistryOptions, image string) ([ | |||
| } | |||
| return rewrittenImages, nil | |||
| } | |||
|
|
|||
| func ChangeImageTag(image string, newTag string) (string, error) { | |||
There was a problem hiding this comment.
Could use a comment about what this function does
divolgin
previously approved these changes
Jan 29, 2024
divolgin
approved these changes
Jan 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Adds support for running KOTS components on Linux Arm64 based clusters / nodes.
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?