Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix processing airgap bundle images #4390

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fix processing airgap bundle images #4390

merged 2 commits into from
Jan 23, 2024

Conversation

sgalsaleh
Copy link
Member

@sgalsaleh sgalsaleh commented Jan 22, 2024 •
edited
Loading

What this PR does / why we need it:

  • Adds support for diff bundles that don't include any images
  • Refactors most of the complex code (technical debt) to be easier to follow/read.
  • Fixes an issue where KOTS tries to push images from airgap bundles that don't have images (this happens when images are pushed from the CLI and the API doesn't have the "images" directory in the bundle).

Which issue(s) this PR fixes:

Fixes SC-97443

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

NONE

Does this PR require documentation?

NONE

@sgalsaleh sgalsaleh added the type::feature New feature or request label Jan 22, 2024
@sgalsaleh sgalsaleh requested a review from cbodonnell January 22, 2024 22:34
@sgalsaleh sgalsaleh merged commit c410809 into main Jan 23, 2024
184 checks passed
@sgalsaleh sgalsaleh deleted the refactor-complex-midstream-code branch January 23, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodonnell cbodonnell cbodonnell approved these changes

Assignees
No one assigned
Labels
type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgalsaleh @cbodonnell