don't fail loading troubleshoot kinds if directory doesn't exist #4212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR modifies the
LoadTSKindsFromPath
function so that it will not fail if the path does not exist, but will instead return an emptyTroubleshootKinds
. This fixes an issue where re-running preflights for a sequence created on a KOTS version prior to 1.96.0 would hang indefinitely and log the error:Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/94221/re-running-preflights-for-versions-created-by-older-versions-of-kots-fails
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE