Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: registry check strips port #4185

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

emosbaugh
Copy link
Member

@emosbaugh emosbaugh commented Nov 30, 2023

What this PR does / why we need it:

Fixes an issue:

kubectl kots install ethan-kots/unstable \
  --namespace default \
  --airgap-bundle ~/Downloads/ethan-kots-0.1.207.airgap \
  --license-file ~/Downloads/ethan-kots-unstable.yaml \
  --shared-password admin123 \
  --kotsadm-registry 127.0.0.1:6443
  • Validating registry information ✗  
Error: Failed to test access to "127.0.0.1" with user "": failed to ping registry: Get "http://127.0.0.1/v2/": dial tcp 127.0.0.1:80: connect: connection refused

After fix:

./bin/kots install ethan-kots/unstable \
  --namespace default \
  --airgap-bundle ~/Downloads/ethan-kots-0.1.207.airgap \
  --license-file ~/Downloads/ethan-kots-unstable.yaml \
  --shared-password admin123 \
  --kotsadm-registry 127.0.0.1:6443
  • Validating registry information ✗  
  • Extracting airgap bundle
Extracting /var/folders/k4/ntyttg4s6r77y6wxvrmm27_h0000gn/T/kotsadm-airgap2538116769/airgap.yaml
...

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Fixes an issue that causes the port to be removed from the `--kotsadm-registry` flag, preventing an airgapped installation from succeeding, with an error validating the registry when performing a kots install, upgrade or pushing admin console images.

Does this PR require documentation?

@emosbaugh emosbaugh added type::bug Something isn't working bug::normal labels Nov 30, 2023
@emosbaugh emosbaugh force-pushed the fix-registry-check-strips-port branch from 06c2f46 to b8c6453 Compare November 30, 2023 16:42
@emosbaugh emosbaugh marked this pull request as ready for review November 30, 2023 16:50
@emosbaugh emosbaugh force-pushed the fix-registry-check-strips-port branch from b8c6453 to b305cde Compare November 30, 2023 19:33
@cbodonnell cbodonnell merged commit fa8e0ac into main Nov 30, 2023
163 checks passed
@cbodonnell cbodonnell deleted the fix-registry-check-strips-port branch November 30, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants