Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e-infra-cleanup workflow #4177

Merged
merged 3 commits into from
Nov 28, 2023
Merged

fix e2e-infra-cleanup workflow #4177

merged 3 commits into from
Nov 28, 2023

Conversation

cbodonnell
Copy link
Contributor

@cbodonnell cbodonnell commented Nov 28, 2023

What this PR does / why we need it:

fixes e2e-infra-cleanup workflow by adding a timestamp to the terraform workspace name so that the creation time can be retrieved more reliably. example of it failing silently https://github.com/replicatedhq/kots/actions/runs/7019202274/job/19096137049

would resolve issues like:

date: invalid date ‘\nWarning: No outputs found\n\nThe state file either has no outputs defined, or all the defined outputs are\nempty. Please define an output in your configuration with the `output`\nkeyword and run `terraform refresh` for it to become available. If you are\nusing interpolation, please verify the interpolated value is not empty. You\ncan use the `terraform console` command to assist.’

and

Error: Output "completion_timestamp" not found

The output variable requested could not be found in the state file. If you
recently added this to your configuration, be sure to run `terraform apply`,
since the state won't be updated with new output variables until that command
is run.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?


Does this PR require documentation?

@cbodonnell cbodonnell marked this pull request as ready for review November 28, 2023 15:19
@cbodonnell cbodonnell merged commit 2ff5f2d into main Nov 28, 2023
164 checks passed
@cbodonnell cbodonnell deleted the cbo/fix-e2e-infra-cleanup branch November 28, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants