-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OKE (Oracle Kubernetes Engine) to distribution support #4117
Added OKE (Oracle Kubernetes Engine) to distribution support #4117
Conversation
Thanks for this @jasonmccampbell! A question about the use-case outlined in #4116 - Is the goal to have OKE to be identified by the |
@cbodonnell yes, that's exactly it. We want to be able to tailor some resources, such as storage classes, specifically for OCI. Am I accomplishing that or is more needed to expose the OKE element? Does this put OKE on equal footing w/ EKS, GKE and others? |
Gotcha. This change will make OKE show up in the KOTS instance reporting, but we will need an update to the We'll have to move these commits over to a branch either way to get all of our tests running (having issues with forks at the current moment), so we can use this as a starting point and add the additional pieces once we release |
Do I have rights / should I push to a branch in this repo do you want to create one and I'll move this PR to be against that branch? I'll look at updating troubleshoot this afternoon. |
I've gone ahead and created As for troubleshoot, ping here if you open a PR and I'll make sure it gets a review from someone. |
Thank you. I retargetted this PR to the new branch and submitted a PR (1387) to the troubleshoot repo. I can retarget that to a branch as well if you like. |
Thanks! Just opened #4119 with this commit and we can get the troubleshoot bump in there too once it's available. |
…4119) * Added OKE (Oracle Kubernetes Engine) to distribution support (#4117) --------- Co-authored-by: Jason McCampbell <[email protected]>
What this PR does / why we need it:
Adds support for Oracle Kubernetes Engine to the distribution list. When the kots installer is used with OKE it should correctly identify it as OKE for
Which issue(s) this PR fixes:
Fixes #4116
Special notes for your reviewer:
Local testing passes, I'm currently testing it in-cluster. Any feedback on other changes is welcome.
Steps to reproduce
NA
Does this PR introduce a user-facing change?
None
Does this PR require documentation?
I don't believe so, but if there is documentation around the distribution enum strings, please let me know.