Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently call embedded-cluster controller nodes 'controller' #4110

Merged
merged 2 commits into from
Oct 31, 2023
Merged

consistently call embedded-cluster controller nodes 'controller' #4110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b739511
consistently call embedded-cluster controller nodes 'controller'
laverya Oct 30, 2023
331eab9
Merge branch 'main' into laverya/cluster-role-is-controller-not-contr…
laverya Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/src/components/apps/EmbeddedClusterManagement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@
htmlFor={`${nodeType}NodeType`}
className="tw-block u-cursor--pointer u-userSelect--none u-textColor--primary u-fontSize--normal u-fontWeight--medium tw-text-center"
>
{nodeType === "controller" ? "controlplane" : nodeType}
{nodeType}
</label>
</div>
))}
Expand All @@ -459,7 +459,7 @@
{generateAddNodeCommandError?.message}
</p>
)}
{!generateAddNodeCommandLoading && generateAddNodeCommand?.command && (

Check warning on line 462 in web/src/components/apps/EmbeddedClusterManagement.tsx

View workflow job for this annotation

GitHub Actions / lint-web 

This line has a length of 83. Maximum allowed is 80
<>
<CodeSnippet
key={selectedNodeTypes.toString()}
Expand Down
Loading