write instance and preflight reports to a secret #4105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodonnell
commented
Oct 20, 2023
cbodonnell
commented
Oct 20, 2023
cbodonnell
commented
Oct 20, 2023
sgalsaleh
reviewed
Oct 20, 2023
sgalsaleh
reviewed
Oct 24, 2023
sgalsaleh
reviewed
Oct 24, 2023
sgalsaleh
reviewed
Oct 24, 2023
sgalsaleh
reviewed
Oct 24, 2023
cbodonnell
force-pushed
the
cbo/sc-91370/airgap-instance-report-secret
branch
from
afd5ef7 to
2f261b0
Compare
sgalsaleh
reviewed
Oct 25, 2023
sgalsaleh
reviewed
Oct 25, 2023
sgalsaleh
reviewed
Oct 25, 2023
sgalsaleh
reviewed
Oct 25, 2023
sgalsaleh
reviewed
Oct 25, 2023
sgalsaleh
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR modifies airgap reporting so that instance and preflight data is written to a k8s secret. Additional dynamic collectors were added to the KOTS support bundle spec to write the data in these secrets to support bundles. This data will be written to
secrets/[namespace]/kotsadm-[appSlug]-instance-report/report.jsonandsecrets/[namespace]/kotsadm-[appSlug]-preflight-report/report.jsonfor the instance and preflight reports, respectively.Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/88191/store-airgap-telemetry-for-the-sdk-in-a-kubernetes-secret
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE