[WIP] allow edit and delete node, move add node modal to separate file #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if embedded-cluster-config exists in kube-system it is helmvm
* generate a node join token * two mutexes, and do not restart successful pods * generate the full node join command * all controllers are also workers * allow arbitrary node roles * role is controller not controller+worker
* wip: refactor helm cluster page, add view node page * add new add node modal * protect routes * move parenthesis * use test data for now * add material react table * start connecting additional api calls, add test pod data * add material react table to display pods * revert change * uncomment real queries * fix useparams import * fix params/routing, update api route * fix loading/refetch state * update generate add node request * add error handling, add mui react table to cluster manage page * move ts-ignore line * remove delete functionality for now
* shorter commands wip * actually return the token * actually return token * return entire commands * handle error * fix lolgic * imports
add kube-proxy/os/kernel to node metrics return 'used' not 'available'
* remove pause and delete columns until the api code is ready, add loading state, update styles * update variable names, fix redirect to cluster manage
* make clipboard work with http, fix redirect to cluster manage page * right align columns, remove placeholders, add namespace column
* check for labels * make labels optional type
* implement 'IsHelmVM' function based on presence of configmap if embedded-cluster-config exists in kube-system it is helmvm * change namespace of embedded cluster config --------- Co-authored-by: Andrew Lavery <[email protected]>
* improve logic around initial cluster flow, comment test data * fix types, redirect on unknown or pending config status if helmvm
alicenstar
force-pushed
the
star/edit-node
branch
from
dc3b556 to
988d44d
Compare
* node role labels * handle having no labels on the first node * f * include a prefix on the label * = not :
* fix config redirect, remove unnecessary code * linting
alicenstar
force-pushed
the
star/edit-node
branch
from
5cc6ffb to
cddf784
Compare
alicenstar
changed the title
alicenstar
changed the title
alicenstar
commented
Oct 20, 2023
| renderRowActionMenuItems={({ closeMenu }) => [ | ||
| <MenuItem | ||
| key="edit" | ||
| onClick={() => { |
There was a problem hiding this comment.
TODO: add the edit and delete functionality to the onClick handlers
laverya
force-pushed
the
embedded-cluster-working-group
branch
from
f5d63d8 to
1c3e657
Compare
|
@alicenstar is this still WIP or can it be closed? |
|
@obfuscurity It can be closed - I'll close it now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?