better embedded cluster usage metrics #4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add kube-proxy/os/kernel to node metrics return 'used' not 'available'
ricardomaraschini
approved these changes
Oct 19, 2023
laverya
merged commit a681da3
into
embedded-cluster-working-group
20 of 22 checks passed
laverya
added a commit
that referenced
this pull request
Oct 22, 2023
add kube-proxy/os/kernel to node metrics return 'used' not 'available'
laverya
added a commit
that referenced
this pull request
Oct 24, 2023
* implement 'IsHelmVM' function based on presence of configmap if embedded-cluster-config exists in kube-system it is helmvm add node metrics add node pod capacity and list of pods to node metrics implement per-node metrics endpoint with podlist * generate a node join token (#4072) * generate a node join token * two mutexes, and do not restart successful pods * generate the full node join command * all controllers are also workers * allow arbitrary node roles * role is controller not controller+worker * change node join command API to accept a list of roles * Add view node page, add new add node modal (#4065) * wip: refactor helm cluster page, add view node page * add new add node modal * protect routes * move parenthesis * use test data for now * add material react table * start connecting additional api calls, add test pod data * add material react table to display pods * revert change * uncomment real queries * fix useparams import * fix params/routing, update api route * fix loading/refetch state * update generate add node request * add error handling, add mui react table to cluster manage page * move ts-ignore line * remove delete functionality for now * update tanstack query imports * shorter embedded-cluster join commands (#4075) * shorter commands wip * actually return the token * actually return token * return entire commands * handle error * fix lolgic * imports * update percentages, add pods, fix link, show expiry (#4077) * fix routing, add missing slash (#4079) * remove test data, uncomment route protection, fix redirect after license upload (#4081) * 24, not 60-something, character join tokens (#4080) * node usage metrics not being collected is not a fatal error (#4082) * include pod usage metrics (#4083) add kube-proxy/os/kernel to node metrics return 'used' not 'available' * remove pause and delete columns, update styles (#4085) * remove pause and delete columns until the api code is ready, add loading state, update styles * update variable names, fix redirect to cluster manage * include 'sudo ./' at the beginning of the node join command (#4088) * format pod CPU and memory usage before returning (#4086) * fixes: clipboard, redirect, columns styling/formatting (#4090) * make clipboard work with http, fix redirect to cluster manage page * right align columns, remove placeholders, add namespace column * determine node roles based on their labels (#4089) * fix vet (#4084) * fix vet * fix tests * complete mock handler * more test * mockgen * cleanup the k0s join token creation pod after completion (#4091) * fix redirect, add column types (#4092) * make labels optional (#4094) * check for labels * make labels optional type * remove the --force flag (#4097) * chore: change embedded cluster config map namespace (#4100) * implement 'IsHelmVM' function based on presence of configmap if embedded-cluster-config exists in kube-system it is helmvm * change namespace of embedded cluster config --------- Co-authored-by: Andrew Lavery <[email protected]> * update redirect to cluster manage page, comment test data (#4096) * improve logic around initial cluster flow, comment test data * fix types, redirect on unknown or pending config status if helmvm * node role labels (#4093) * node role labels * handle having no labels on the first node * f * include a prefix on the label * = not : * fix config redirect, remove unnecessary code (#4104) * fix config redirect, remove unnecessary code * linting * quite a bit of renaming (#4106) * renaming things to 'embedded-cluster' * rename frontend * import ordering * undo goland's wonderful formatting changes * function naming * undo whitespace change * Apply suggestions from code review Co-authored-by: Salah Al Saleh <[email protected]> * address review comments * return to excluding helmvm from some tests * another set of mistaken find-replace --------- Co-authored-by: Star Richardson <[email protected]> Co-authored-by: Diamon Wiggins <[email protected]> Co-authored-by: Salah Al Saleh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include pod usage metrics
add kube-proxy/os/kernel to node metrics
return 'used' not 'available'
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?