fix: clear v1beta2 helm directory before writing new charts #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodonnell
changed the title
cbodonnell
changed the title
sgalsaleh
previously approved these changes
Sep 26, 2023
sgalsaleh
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes an issue where the charts from the previously deployed version were not being removed if they were no longer part of the current version. This happened because the
helmdirectory for v1beta2 charts was not cleared out before the charts for the current version were written, so even if the chart was not part of the current version, KOTS would still include it as part of the deployment.Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/89845/v1beta2-helm-charts-don-t-get-removed-when-excluded-later-on
Special notes for your reviewer:
Steps to reproduce
Install a chart that has a conditional
excludefield from a config option. Toggle the config option to exclude the chart. Observe that the chart is excluded and uninstalled.Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE