Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'Lookup' template function #4032

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

sgalsaleh
Copy link
Member

@sgalsaleh sgalsaleh commented Sep 8, 2023

What this PR does / why we need it:

Adds support for Lookup function (similar to Helm)

Which issue(s) this PR fixes:

Fixes SC-85466

Special notes for your reviewer:

No tests added for now as this is directly using the Helm lookup functionality.

Steps to reproduce

Does this PR introduce a user-facing change?

Adds support for [Lookup](/reference/template-functions-static-context#lookup) template function.

Does this PR require documentation?

TBD

@sgalsaleh sgalsaleh requested a review from cbodonnell September 8, 2023 23:44
@sgalsaleh sgalsaleh added the type::feature New feature or request label Sep 8, 2023
Copy link
Contributor

@cbodonnell cbodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests for this new feature? May be able to leverage dynamic.Interface (and maybe discovery.DiscoveryInterface) to do this in unit tests as we currently do for the clientset kubernetes.Interface param of the StaticCtx struct.

@sgalsaleh sgalsaleh changed the title Add support for Lookup function Add support for 'Lookup' template function Sep 19, 2023
@sgalsaleh sgalsaleh merged commit 0a3a330 into main Sep 19, 2023
@sgalsaleh sgalsaleh deleted the add-lookup-function-to-kots branch September 19, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants