Skip to content

Commit

Permalink
use creds to push to dockerhub
Browse files Browse the repository at this point in the history
  • Loading branch information
sgalsaleh committed Nov 27, 2023
1 parent d005ce7 commit 8c3a76b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,10 @@ jobs:
uses: actions/checkout@v3
- uses: ./.github/actions/build-push-kotsadm-image
with:
image-name: ttl.sh/salah/kotsadm:${{ needs.generate-tag.outputs.tag }}
image-name: index.docker.io/kotsadm/kotsadm:${{ needs.generate-tag.outputs.tag }}
git-tag: ${{ needs.generate-tag.outputs.tag }}
# registry-username: ${{ secrets.DOCKERHUB_USER }}
# registry-password: ${{ secrets.DOCKERHUB_PASSWORD }}
registry-username: ${{ secrets.DOCKERHUB_USER }}
registry-password: ${{ secrets.DOCKERHUB_PASSWORD }}
- uses: azure/docker-login@v1
env:
DOCKER_CONFIG: ./.docker
Expand Down
4 changes: 0 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,6 @@ build-alpha:

.PHONY: build-release
build-release:
docker pull ttl.sh/salah/kotsadm:${GIT_TAG}
docker tag ttl.sh/salah/kotsadm:${GIT_TAG} kotsadm/kotsadm:${GIT_TAG}
docker push kotsadm/kotsadm:${GIT_TAG}

mkdir -p bin/docker-archive/kotsadm
skopeo copy docker-daemon:kotsadm/kotsadm:${GIT_TAG} docker-archive:bin/docker-archive/kotsadm/${GIT_TAG}

Expand Down

0 comments on commit 8c3a76b

Please sign in to comment.