Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Salah Al Saleh <[email protected]>
  • Loading branch information
laverya and sgalsaleh authored Oct 23, 2023
1 parent 3289ee5 commit 7258c81
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/handlers/embedded_cluster_node_join_command.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"github.com/replicatedhq/kots/pkg/embeddedcluster"
"github.com/replicatedhq/kots/pkg/k8sutil"
"github.com/replicatedhq/kots/pkg/logger"
"github.com/replicatedhq/kots/pkg/store/kotsstore"
"github.com/replicatedhq/kots/pkg/store"

Check failure on line 11 in pkg/handlers/embedded_cluster_node_join_command.go

View workflow job for this annotation

GitHub Actions / ci-test-kots

"github.com/replicatedhq/kots/pkg/store" imported and not used

Check failure on line 11 in pkg/handlers/embedded_cluster_node_join_command.go

View workflow job for this annotation

GitHub Actions / vet-kots

"github.com/replicatedhq/kots/pkg/store" imported and not used

Check failure on line 11 in pkg/handlers/embedded_cluster_node_join_command.go

View workflow job for this annotation

GitHub Actions / vet-kots

"github.com/replicatedhq/kots/pkg/store" imported and not used

Check failure on line 11 in pkg/handlers/embedded_cluster_node_join_command.go

View workflow job for this annotation

GitHub Actions / build-kots

"github.com/replicatedhq/kots/pkg/store" imported and not used

Check failure on line 11 in pkg/handlers/embedded_cluster_node_join_command.go

View workflow job for this annotation

GitHub Actions / build-kotsadm

"github.com/replicatedhq/kots/pkg/store" imported and not used
)

type GenerateEmbeddedClusterNodeJoinCommandResponse struct {
Expand All @@ -34,7 +34,7 @@ func (h *Handler) GenerateEmbeddedClusterNodeJoinCommand(w http.ResponseWriter,
}

store := kotsstore.StoreFromEnv()

Check failure on line 36 in pkg/handlers/embedded_cluster_node_join_command.go

View workflow job for this annotation

GitHub Actions / ci-test-kots

undefined: kotsstore

Check failure on line 36 in pkg/handlers/embedded_cluster_node_join_command.go

View workflow job for this annotation

GitHub Actions / vet-kots

undefined: kotsstore

Check failure on line 36 in pkg/handlers/embedded_cluster_node_join_command.go

View workflow job for this annotation

GitHub Actions / vet-kots

undefined: kotsstore

Check failure on line 36 in pkg/handlers/embedded_cluster_node_join_command.go

View workflow job for this annotation

GitHub Actions / build-kots

undefined: kotsstore

Check failure on line 36 in pkg/handlers/embedded_cluster_node_join_command.go

View workflow job for this annotation

GitHub Actions / build-kotsadm

undefined: kotsstore
token, err := store.SetEmbeddedClusterInstallCommandRoles(generateEmbeddedClusterNodeJoinCommandRequest.Roles)
token, err := store.GetStore().SetEmbeddedClusterInstallCommandRoles(generateEmbeddedClusterNodeJoinCommandRequest.Roles)
if err != nil {
logger.Error(fmt.Errorf("failed to set k0s install command roles: %w", err))
w.WriteHeader(http.StatusInternalServerError)
Expand Down

0 comments on commit 7258c81

Please sign in to comment.