Skip to content

Commit

Permalink
add comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sgalsaleh committed Dec 19, 2024
1 parent d860cc5 commit 2e55aa6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/plan/embeddedcluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ func executeECUpgrade(s store.Store, p *types.Plan, step *types.PlanStep) error
return errors.Wrap(err, "failed to load kotskinds from path")
}

// TODO (@salah): old kots should not be constructing the new installation object
newInstall := &ecv1beta1.Installation{
TypeMeta: metav1.TypeMeta{
APIVersion: ecv1beta1.GroupVersion.String(),
Expand Down
4 changes: 4 additions & 0 deletions pkg/plan/plan.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ func PlanUpgrade(s store.Store, opts PlanUpgradeOptions) (*types.Plan, error) {
Owner: types.StepOwnerKOTS,
})

// TODO (@salah): add a step to upgrade kots here
// to make sure later steps are executed by the new version,
// as old kots might not be able to parse new kots kinds (and EC config)

// embedded cluster upgrade
if ecVersion != util.EmbeddedClusterVersion() {
plan.Steps = append(plan.Steps, &types.PlanStep{
Expand Down

0 comments on commit 2e55aa6

Please sign in to comment.