feat: reporting back installation and upgrade metrics #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-89250/adoption-metrics-fire-events-for-install
branch
from
efafc68 to
771dbeb
Compare
reporting back installation and upgrades data.
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-89250/adoption-metrics-fire-events-for-install
branch
from
771dbeb to
7b46dd5
Compare
emosbaugh
reviewed
Oct 4, 2023
cmd/helmvm/token.go
Outdated
| encodedToken := bytes.NewBuffer(nil) | ||
| encoder := base64.NewEncoder(base64.StdEncoding, encodedToken) | ||
| marshaler := json.NewEncoder(encoder) | ||
| if err := marshaler.Encode(token); err != nil { |
There was a problem hiding this comment.
How about an Encode() function on the JoinToken struct?
There was a problem hiding this comment.
that makes sense. done.
pkg/metrics/sender.go
Outdated
| url := fmt.Sprintf("%s/helmbin_metrics/%s", s.baseURL, ev.Title()) | ||
| payload, err := s.payload(ev) | ||
| if err != nil { | ||
| logrus.Infof("unable to get payload for event %s: %s", ev.Title(), err) |
There was a problem hiding this comment.
Why is this info and the rest level debug?
There was a problem hiding this comment.
my bad, it should have been a debugf as well. fixed.
we are using debugf in all other logrus calls except one.
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-89250/adoption-metrics-fire-events-for-install
branch
from
7011b73 to
4bb7cbf
Compare
emosbaugh
approved these changes
Oct 5, 2023
ricardomaraschini
deleted the
ricardomaraschini/sc-89250/adoption-metrics-fire-events-for-install
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporting back Installation, Join, and Upgrades data. This work is described in details here.
HelmVM adoption metrics
The reporting is based on events, some events will be generated by the installer (that this PR implements) and some by an operator running on the cluster (still to be implemented). The operator is responsible for keeping track of the nodes that compose the cluster while the installer is responsible for reporting installation, upgrades, and joins successes and failures.
These are the events reported through this PR:
This PR depends on https://github.com/replicatedhq/vandoor/pull/4333.