feat: deploying admin console with the embedded license #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a license exists inside the binary we configure admin console to use it. if no license was found deploys admin console as we used to (without license).
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-89490/embed-license-in-helmvm-binary
branch
from
1f579de to
ee80394
Compare
laverya
reviewed
Sep 26, 2023
Comment on lines
+80
to
+85
| helmValues["automation"] = map[string]interface{}{ | ||
| "license": map[string]interface{}{ | ||
| "slug": license.Spec.AppSlug, | ||
| "data": string(raw), | ||
| }, | ||
| } |
There was a problem hiding this comment.
I would prefer if this was a safeadd (ie it doesn't wipe automation.somethingelse) but this works for now
laverya
approved these changes
Sep 26, 2023
ricardomaraschini
deleted the
ricardomaraschini/sc-89490/embed-license-in-helmvm-binary
branch
emosbaugh
pushed a commit
that referenced
this pull request
Aug 26, 2024
* watch k0s chart objects * do not update k0s cluster object if it is still applying charts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a license exists inside the binary we configure admin console to use it. if no license was found deploys admin console as we used to (without license).