-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable kurl-proxy in the admin console helm chart #261
Conversation
// To allow older versions of Admin Console to still work, | ||
// we need to retain the "admin console service". It gets | ||
// removed when kurlProxy is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no older versions of admin console - we pin the version of the chart + kotsadm as part of the binary, so you can remove the "handle old versions" config items
This should not be merged until replicatedhq/kots-helm#32 has been merged and a new helm chart version has been tagged. This PR should likely include a bump to the chart version, see https://github.com/replicatedhq/embedded-cluster/blob/cd4cc4c/Makefile#L7 |
Once replicatedhq/kots-helm#32 and replicatedhq/kots#4344 are merged, ensure we update |
Currently waiting on release for those two, plus a re-review here |
* chore: remove metrics service and kube-rbac-proxy image * f
This change will allow reaching admin console via a secure connection. Users get the same workflow as the KOTS addon on from kURL i.e the can upload their own certs or have self signed certs generated to secure admin console.
Related to https://app.shortcut.com/replicated/story/94724