chore: create workflow to update makefile dependencies #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetches latest version for all embedded stuff and update them in the makefile. creates a pr at the end.
laverya
reviewed
Nov 8, 2023
| name: Custom Dependabot | ||
| on: | ||
| schedule: | ||
| - cron: '0 0 * * *' |
There was a problem hiding this comment.
How often is this? add a comment IMO
laverya
reviewed
Nov 8, 2023
.github/workflows/dependencies.yaml
Outdated
| - name: AdminConsole | ||
| run: | | ||
| export VERSION=`curl https://api.github.com/repos/replicatedhq/kots-helm/tags | jq -r .[].name | grep -v alpha | head -1 | tr -d v` | ||
| sed -i "/^ADMIN_CONSOLE_CHART_VERSION/c\ADMIN_CONSOLE_CHART_NAME = $VERSION" Makefile |
There was a problem hiding this comment.
you're changing the env var name here
ADMIN_CONSOLE_CHART_VERSION/c\ADMIN_CONSOLE_CHART_NAME
There was a problem hiding this comment.
Yeah, fixed. Thanks.
laverya
reviewed
Nov 8, 2023
laverya
approved these changes
Nov 13, 2023
|
I am merging this, let's see how it looks like tomorrow. |
emosbaugh
pushed a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetches latest version for all embedded stuff and update them in the makefile. creates a pr at the end.