Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix 'timed out waiting for admin console: <nil>' #164

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

ricardomaraschini
Copy link
Contributor

if the timeout is reached but no error happen inside the func lasterr will be nil but err will have the timeout. on this scenario lasterr should be the actual timeout error.

if the timeout is reached but no error happen inside the func lasterr
will be nil but err will have the timeout. on this scenario lasterr
should be the actual timeout error.
@ricardomaraschini ricardomaraschini merged commit 74146af into main Oct 31, 2023
12 checks passed
@ricardomaraschini ricardomaraschini deleted the fix-nil-error branch October 31, 2023 12:38
emosbaugh pushed a commit that referenced this pull request Aug 26, 2024
…164)

* update embedded-cluster-kinds to add new status field

* set pending charts when relevant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants