store things following XDG standards #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to rework this again to use XDG_DATA_HOME/XDG_STATE_HOME as appropriate bag of worms here |
ricardomaraschini
approved these changes
Oct 16, 2023
emosbaugh
pushed a commit
that referenced
this pull request
Aug 26, 2024
when deciding to start or not an upgrade we should take into account what is the current embedded cluster we are running on. without this fix we end up starting a cluster upgrade when it is not necessary. we were using the kubernetes version (as in `kubectl version`) to determine if an upgrade was necessary or not. it turns out that when installed with k0s version v1.29.1+k0s.1 the kubernetes version reported is v1.29.1+k0s (notice the missing .1 at the end). because of this the running verion was never equal to the desired version (v1.29.1+k0s.1 != v1.29.1+k0s). now we take into account the actual embedded cluster version. we do so through an environment variable. this environment variable will change only when the new operator deployment takes place (add-on upgrade) and at that stage the kubernetes has already been upgraded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html