Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save rendered fiber IDs for routine use #11

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Save rendered fiber IDs for routine use #11

merged 1 commit into from
Nov 7, 2023

Conversation

markerikson
Copy link

This PR:

  • Updates the RDT internals to capture IDs for all fibers that rendered in a given commit, for use in the component commit timeline

bvaughn
bvaughn approved these changes Nov 7, 2023
View reviewed changes
Copy link

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. I like the // REPLAY comment format :)

@markerikson
Copy link
Author

Yeah, I figured it was worth calling out a few of the specific customizations in the code, beyond the diffs in our fork branch.

@markerikson markerikson merged commit fdf3b34 into feature/replay-react-devtools Nov 7, 2023
1 check passed
@markerikson markerikson deleted the feature/FE-2012-component-commit-data branch November 7, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markerikson @bvaughn