Fix Flow issues in Replay RDT fork

replayio · Jul 1, 2024 · 680ad6d · 680ad6d
1 parent 849217d
commit 680ad6d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/packages/react-devtools-extensions/src/backend.js b/packages/react-devtools-extensions/src/backend.js
@@ -24,9 +24,9 @@ function setup(hook: ?DevToolsHook) {
     return;
   }
 
-  const bridge = new Bridge({
+  const bridge = new Bridge<any, any>({
     listen(fn) {
-      const listener = event => {
+      const listener = (event: any) => {
         if (
           event.source !== window ||
           !event.data ||
@@ -42,7 +42,7 @@ function setup(hook: ?DevToolsHook) {
         window.removeEventListener('message', listener);
       };
     },
-    send(event, payload, transferable) {
+    send(event: string, payload: any, transferable: any) {
       window.postMessage(
         {
           source: 'react-devtools-bridge',

diff --git a/packages/react-devtools-shared/src/backend/agent.js b/packages/react-devtools-shared/src/backend/agent.js
@@ -216,11 +216,11 @@ export default class Agent extends EventEmitter<{
       inData,
     ) => {
       let rv;
-      this._bridge = {
+      this._bridge = ({
         send(event, data) {
           rv = {event, data};
         },
-      };
+      }: any);
       try {
         this[inEvent](inData);
       } catch (err) {

diff --git a/packages/react-devtools-shared/src/backend/console.js b/packages/react-devtools-shared/src/backend/console.js
@@ -136,7 +136,11 @@ export function registerRenderer(
   // currentDispatcherRef gets injected for v16.8+ to support hooks inspection.
   // getCurrentFiber gets injected for v16.9+.
   if (currentDispatcherRef != null && typeof getCurrentFiber === 'function') {
-    const {ReactTypeOfWork} = getInternalReactConstants(version);
+    const {ReactTypeOfWork} = getInternalReactConstants(
+      version,
+      // REPLAY Our fork will never run this code anyway, make Flow happy
+      () => 0,
+    );
 
     injectedRenderers.set(renderer, {
       currentDispatcherRef,

diff --git a/packages/react-devtools-shared/src/backend/renderer.js b/packages/react-devtools-shared/src/backend/renderer.js
@@ -2485,7 +2485,7 @@ export function attach(
     if (
       mostRecentlyInspectedElement !== null &&
       mostRecentlyInspectedElement.id === id &&
-      fiberRenderered
+      fiberRendered
     ) {
       // If this Fiber has updated, clear cached inspected data.
       // If it is inspected again, it may need to be re-run to obtain updated hooks values.