Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically collect call graph from tdd_repro #15

Merged
merged 44 commits into from
Oct 21, 2024

Conversation

Domiii
Copy link

@Domiii Domiii commented Sep 23, 2024

@Domiii Domiii self-assigned this Sep 23, 2024
@Domiii Domiii force-pushed the dominik/pro-864-6a-test-initial-runtime-data-hypotheses branch from c192533 to cd9f723 Compare October 1, 2024 16:51
@Domiii Domiii changed the title [PRO-864] 6a. Test Initial Runtime Data Hypotheses Automatically collect call graph from tdd_repro Oct 7, 2024
@Domiii Domiii requested a review from toshok October 7, 2024 12:33
@@ -0,0 +1,2272 @@
2024-10-01 11:28:38,309 WARNING ⚠ TDD is enabled. Agents have access to the test patch and will not try to reproduce the problem. ⚠

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove these handpicked logs? These are really large and don't seem necessary without associated docs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the repo is the perfect place to keep track of large log files that sample our investigations.
Where do you suggest keeping them?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, to rephrase, what are these log files used for? If we're just storing these log files here we could use google drive instead.

# Inject test injecter:
# TODO: generalize the file location
# (Choosing urls.py is a hack: we know that `urls.py` is one of the dynamic imports from runtests.py, so appending to it works.)
test_file_to_override = os.path.join(container_test_folder, "urls.py")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: I still need to fix this before merging.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled for now

@Domiii Domiii merged commit ac66cfe into main Oct 21, 2024
2 of 4 checks passed
@Domiii Domiii deleted the dominik/pro-864-6a-test-initial-runtime-data-hypotheses branch October 21, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants