Fix timer stop (#155)

* Update timer params

* Refactor params

* Refactor

* Fix linter

* Update README.md

README.md

@@ -40,6 +40,44 @@ Administration => Roles & Permissions
 - Test: `rake test`
 - Watch Assets: `rake watch`
 
+## Time Tracking Flow
+
+```mermaid
+stateDiagram-v2
+    [*] --> CheckingSession : Start Request
+    
+    CheckingSession --> Conflict : Session Exists
+    Conflict --> [*] : Return Conflict
+    
+    CheckingSession --> SessionCreation : No Active Session
+    SessionCreation --> ValidatingSession : Create Session
+    
+    ValidatingSession --> IssueAssociation : Valid Session
+    ValidatingSession --> Error : Invalid Session
+    Error --> [*] : Return Unprocessable
+    
+    IssueAssociation --> ConnectorValidation : Issue Connector Init
+    ConnectorValidation --> Error : Connector Invalid
+    Error --> [*] : Return Unprocessable
+    
+    ConnectorValidation --> CheckingFinished : Connector Valid
+    CheckingFinished --> Finalize : Session Finished
+    CheckingFinished --> UpdateTimer : Session Active
+    
+    Finalize --> TimeEntryCreation : Mark Finished
+    TimeEntryCreation --> Success : Create Time Entries
+    Success --> [*] : Return Success
+    
+    UpdateTimer --> TimerUpdated : Update Session
+    TimerUpdated --> Success : Valid Update
+    TimerUpdated --> Error : Invalid Update
+    Error --> [*] : Return Unprocessable
+    
+    destroy : Destroy Session
+    destroy --> Cancel : Cancel Timer
+    Cancel --> [*] : Return Cancel
+```
+
 ## Copyright
 
 Copyright 2021-2024 [Renuo AG](https://www.renuo.ch/), published under the MIT license.

app/controllers/time_tracker_controller.rb

@@ -37,7 +37,11 @@ def create
   end
 
   def update
-    return render_js(:update, :unprocessable_entity) unless @current_timer_session.update(timer_params)
+    updated_params = timer_params
+
+    updated_params[:timer_end] = user_time_zone.now.asctime if updated_params[:timer_end].blank?
+
+    return render_js(:update, :unprocessable_entity) unless @current_timer_session.update(updated_params)
 
     if @current_timer_session.session_finished?
       return render_js(:update, :unprocessable_entity) unless @current_timer_session.update(finished: true)

test/functional/time_tracker_controller_test.rb

@@ -132,6 +132,7 @@ def setup
       issue_ids: ['1']
     } }, xhr: true
     assert_response 200
+    assert_equal TimerSession.last.finished, true
   end
 
   test '#update - with no end time' do