Unstable #18
Open
Unstable #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't pass originalFunctionPtr and reentryIsland to fixupInstructions, it only needs the offset.
to extract the value of eip.
Compiling mach_override.c with gcc 4.2.1 via gcc -Wall -pedantic -std=c99 -c mach_override.c would yield a lot of warnings saying 'warning: overflow in implicit constant conversion' in the opcode arrays. The reason was that 'char' is a signed type with this compiler, so 0x90 (as well as 0xFF) were too large, causing an overflow. We don't really care whether it's signed or unsigned, but in order to silence warnings in -pedantic builds just use 'unsigned char' to be explicit.
Fix x86 builds on Clang 3.2/Xcode 4.6.
Replacing atomic_mov64 with an implementation that just calls OSAtomicCompareAndSwap64Barrier on all OSes.
[CHANGE] OSAtomicCompareAndSwap64Barrier instead of inline asm. (Jørgen P. Tjernø)
strerror, our test-victim function that we override, returns a slightly-different result on 10.6 and 10.7+. We used to call Gestalt to decide which we should expect, but Gestalt is deprecated. Apparently the current "best" solution is to read SystemVersion.plist (ref https://twitter.com/rentzsch/status/373203814993494016) but that's a lot of code to write just to decide on which string to expect. So this code now will accept either. But the assert* code was hard to follow with the strcmp() == 0, so I upgraded that yak as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.