Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plonk: multiprover: constraint-system: Implement MpcCircuit for MpcPlonkCircuit #9

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

joeykraut
Copy link
Member

Purpose

This PR implements the MpcCircuit trait for the MpcPlonkCircuit type. This trait is the interface on which a circuit is constructed, i.e. gates added, variables allocated, etc. Effectively this trait represents the constraint system frontend.

This implementation closely mirrors the single-prover implementation; with methods removed that are unneeded in our case (e.g. plookup).

Testing

  • Unit and integration tests pass

@joeykraut joeykraut requested a review from akirillo October 21, 2023 01:14
@joeykraut joeykraut marked this pull request as ready for review October 21, 2023 01:14
Copy link

@akirillo akirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change requested, lgtm otherwise

@joeykraut joeykraut force-pushed the joey/multiprover-bootstrap branch from 46795b4 to df7a83a Compare October 21, 2023 17:00
@joeykraut joeykraut merged commit 0f47cc0 into main Oct 21, 2023
1 check failed
@joeykraut joeykraut deleted the joey/multiprover-bootstrap branch October 21, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants