Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plonk: proof-system: proof-linking: Implement proof linking prover and verifier #40

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

joeykraut
Copy link
Member

@joeykraut joeykraut commented Jan 4, 2024

Purpose

This PR gives the initial implementation of a prover and verifier for the proof linking protocol in the single-prover setting. This implementation is incomplete: we need to use the same masking polynomials when computing the wiring polynomials between the r1cs proof and linking proof. This change, and further testing, are deferred to a follow up PR.

Testing

  • All tests pass assuming masking polynomials have been nullified

@joeykraut joeykraut force-pushed the joey/proof-linking-protocol branch from 43d23d2 to 2de0a28 Compare January 4, 2024 22:16
@joeykraut joeykraut requested a review from akirillo January 4, 2024 22:16
@joeykraut joeykraut marked this pull request as ready for review January 4, 2024 22:16
@joeykraut joeykraut force-pushed the joey/proof-linking-protocol branch 2 times, most recently from 4c85994 to 5124865 Compare January 4, 2024 22:26
Copy link

@akirillo akirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is super clean, but we should be doing full KZG opening proof verification

plonk/src/proof_system/proof_linking.rs Outdated Show resolved Hide resolved
plonk/src/proof_system/proof_linking.rs Show resolved Hide resolved
plonk/src/proof_system/proof_linking.rs Outdated Show resolved Hide resolved
plonk/src/proof_system/proof_linking.rs Show resolved Hide resolved
@joeykraut joeykraut force-pushed the joey/proof-linking-protocol branch from 5124865 to 99ce8d7 Compare January 5, 2024 01:50
@joeykraut joeykraut requested a review from akirillo January 5, 2024 01:50
@joeykraut joeykraut merged commit 7977755 into main Jan 5, 2024
0 of 2 checks passed
@joeykraut joeykraut deleted the joey/proof-linking-protocol branch January 5, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants