Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relation: proof-linking: Add group placement over roots of unity #38

Merged
merged 3 commits into from
Jan 3, 2024
Merged

relation: proof-linking: Add group placement over roots of unity #38

merged 3 commits into from
Jan 3, 2024

Conversation

joeykraut
Copy link
Member

@joeykraut joeykraut commented Jan 2, 2024 •
edited
Loading

Purpose

This PR refactors the implementation of proof-linking arithmetization to have an alignment which suggests the roots-of-unity that the proof linking gates should be placed on. This allows proofs of different domain sizes to link with one another.

Testing

  • All unit tests pass

@joeykraut joeykraut force-pushed the joey/linking-roots-of-unity branch from b6e1cde to e10f4ec Compare January 2, 2024 23:34
@joeykraut joeykraut marked this pull request as ready for review January 2, 2024 23:35
@joeykraut joeykraut requested a review from akirillo January 2, 2024 23:36
akirillo
akirillo reviewed Jan 3, 2024
View reviewed changes
Copy link

@akirillo akirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of readability nits since this is understandable a tough implementation to wrap one's head around. But I do want to be sure that PlonkCircuit::circuit_alignment() is correctly implemented/used before approving

relation/src/proof_linking/arithmetization.rs Outdated Show resolved Hide resolved
relation/src/proof_linking/arithmetization.rs Outdated Show resolved Hide resolved
relation/src/proof_linking/arithmetization.rs Outdated Show resolved Hide resolved
relation/src/proof_linking/arithmetization.rs Outdated Show resolved Hide resolved
relation/src/constraint_system.rs Show resolved Hide resolved
relation/src/proof_linking/arithmetization.rs Outdated Show resolved Hide resolved
relation/src/proof_linking/arithmetization.rs Show resolved Hide resolved
relation/src/proof_linking/arithmetization.rs Outdated Show resolved Hide resolved
relation/src/proof_linking/arithmetization.rs Outdated Show resolved Hide resolved
relation/src/constraint_system.rs Outdated Show resolved Hide resolved
@joeykraut joeykraut force-pushed the joey/linking-roots-of-unity branch from e10f4ec to 3dae0a1 Compare January 3, 2024 20:08
@joeykraut joeykraut requested a review from akirillo January 3, 2024 20:08
akirillo
akirillo approved these changes Jan 3, 2024
View reviewed changes
Copy link

@akirillo akirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple last nits, nice work here

relation/src/proof_linking/arithmetization.rs Outdated Show resolved Hide resolved
relation/src/proof_linking/arithmetization.rs Outdated Show resolved Hide resolved
@joeykraut joeykraut force-pushed the joey/linking-roots-of-unity branch from 3dae0a1 to 0d7d27c Compare January 3, 2024 21:02
@joeykraut joeykraut force-pushed the joey/linking-roots-of-unity branch from 0e35c37 to 0458695 Compare January 3, 2024 22:01
@joeykraut joeykraut merged commit 07bf762 into main Jan 3, 2024
1 check failed
@joeykraut joeykraut deleted the joey/linking-roots-of-unity branch January 3, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirillo akirillo akirillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeykraut @akirillo