fix(share/getters): set minTimeout (celestiaorg#3591)

share/getters/cascade.go

@@ -3,6 +3,7 @@ package getters
 import (
 	"context"
 	"errors"
+	"time"
 
 	"go.opentelemetry.io/otel/attribute"
 	"go.opentelemetry.io/otel/trace"
@@ -119,13 +120,21 @@ func cascadeGetters[V any](
 		}
 	}()
 
+	minTimeout := time.Duration(0)
+	_, ok := ctx.Deadline()
+	if !ok {
+		// in this case minTimeout will be applied for all getters,so each of them
+		// will have 1 minute timeout.
+		minTimeout = time.Minute
+	}
+
 	for i, getter := range getters {
 		log.Debugf("cascade: launching getter #%d", i)
 		span.AddEvent("getter launched", trace.WithAttributes(attribute.Int("getter_idx", i)))
 
 		// we split the timeout between left getters
 		// once async cascadegetter is implemented, we can remove this
-		getCtx, cancel := ctxWithSplitTimeout(ctx, len(getters)-i, 0)
+		getCtx, cancel := ctxWithSplitTimeout(ctx, len(getters)-i, minTimeout)
 		val, getErr := get(getCtx, getter)
 		cancel()
 		if getErr == nil {

share/getters/cascade_test.go

@@ -67,6 +67,13 @@ func TestCascade(t *testing.T) {
 			return nil, ctx.Err()
 		}).AnyTimes()
 
+	stuckGetter := mocks.NewMockGetter(ctrl)
+	stuckGetter.EXPECT().GetEDS(gomock.Any(), gomock.Any()).
+		DoAndReturn(func(ctx context.Context, _ *header.ExtendedHeader) (*rsmt2d.ExtendedDataSquare, error) {
+			<-ctx.Done()
+			return nil, ctx.Err()
+		}).AnyTimes()
+
 	get := func(ctx context.Context, get share.Getter) (*rsmt2d.ExtendedDataSquare, error) {
 		return get.GetEDS(ctx, nil)
 	}
@@ -116,4 +123,10 @@ func TestCascade(t *testing.T) {
 		_, err := cascadeGetters(ctx, getters, get)
 		assert.NoError(t, err)
 	})
+
+	t.Run("Stuck getter", func(t *testing.T) {
+		getters := []share.Getter{stuckGetter, successGetter}
+		_, err := cascadeGetters(ctx, getters, get)
+		assert.NoError(t, err)
+	})
 }