Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(start/testing): update imports #12186

Merged
merged 2 commits into from
Oct 25, 2024
Merged

docs(start/testing): update imports #12186

merged 2 commits into from
Oct 25, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Oct 24, 2024

Closes #12185

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 71cbd84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 linked an issue Oct 24, 2024 that may be closed by this pull request
@ondrejsevcik
Copy link

It would be nice to include some examples in the documentation that show how to work with nested routes. The current documentation (v6) has the following one:

const router = createBrowserRouter([
  {
    path: "/",
    element: <Root />,
    loader: rootLoader,
    children: [
      {
        path: "team",
        element: <Team />,
        loader: teamLoader,
      },
    ],
  },
]);

@brophdawg11
Copy link
Contributor Author

The docs are still in flux during the prerelease so we'll be expanding them as we get closer to a stable release - and we'll get some info on nested routes in there 👍

@brophdawg11 brophdawg11 merged commit b660a7f into dev Oct 25, 2024
1 check passed
@brophdawg11 brophdawg11 deleted the brophdawg11/docs branch October 25, 2024 14:51
@MichaelDeBoey MichaelDeBoey changed the title Docs: update testing docs imports docs(start/testing): update imports Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: v7 - unable to import react-router/testing
3 participants