Fix encoded # in path parameter causes route to be evaluated differently

remix-run · Sep 11, 2024 · 434c290 · 434c290
1 parent 7372aff
commit 434c290
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/contributors.yml b/contributors.yml
@@ -282,3 +282,4 @@
 - yuleicul
 - zeromask1337
 - zheng-chuang
+- dunnai
diff --git a/packages/router/utils.ts b/packages/router/utils.ts
@@ -1079,7 +1079,11 @@ export function decodePath(value: string) {
   try {
     return value
       .split("/")
-      .map((v) => decodeURIComponent(v).replace(/\//g, "%2F"))
+      .map(
+        (v) => decodeURIComponent(v)
+          .replace(/\//g, "%2F")
+          .replace(/#/g, "%23")
+      )
       .join("/");
   } catch (error) {
     warning(