Improve train metrics setting #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disable by default
remijouannet
reviewed
Aug 4, 2024
| setting_type = "startup", | ||
| default_value = false, | ||
| setting_type = "runtime-global", | ||
| default_value = true, |
There was a problem hiding this comment.
please don't change the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Details
I found out that the train metrics from this mod were creating 100k+ active series on my Grafana Cloud account that would have soon cost me over $1k / mo. The server is a long-running project, so I was dismayed when the this disable feature was a "startup" setting rather than an "runtime-global". As far as I can tell, that meant I couldn't change the setting for my server after it was created. Setting it to "runtime-global" has seemingly allowed me to turn these metrics on and off as I please.
Lastly, in my opinion, these train metrics simply don't scale with Factorio and they should be disabled by default or reworked to bring the cardinality way down.