-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable client parser to retain carriage return characters #902
fix: enable client parser to retain carriage return characters #902
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #902 +/- ##
==========================================
+ Coverage 92.59% 92.90% +0.31%
==========================================
Files 7 7
Lines 135 141 +6
Branches 30 30
==========================================
+ Hits 125 131 +6
Misses 8 8
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left 2 comments
@remarkablemark added tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What is the motivation for this pull request?
Bug fix
What is the current behavior?
Closes #420
Addresses html-react-parser #864
What is the new behavior?
Checklist: