Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor baseline read/write #3845

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor baseline read/write #3845

wants to merge 2 commits into from

Conversation

vio
Copy link
Member

@vio vio commented Sep 23, 2023 •
edited
Loading

  • refactor(cli-utils): writeBaseline - same param order as for writeFile
  • use fix fs.writeFile instead of fs-extra

@vio vio changed the title refactor baselines Refactor baseline read/write Sep 23, 2023
@socket-security
Copy link

socket-security bot commented Sep 23, 2023 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/stream-json 1.7.3...1.7.4 None +1/-1 23.7 kB types
@types/stream-chain 2.0.1...2.0.2 None +0/-0 4.44 kB types

@vio vio force-pushed the refactor-baselines branch 2 times, most recently from 148201d to 3cea708 Compare September 23, 2023 17:29
@relativeci
Copy link

relativeci bot commented Sep 23, 2023 •
edited
Loading

Job #9680: Bundle Size — 304.07KiB (+0.05%).

e7948e0(current) vs 4f149fb master#9678(baseline)

⚠️ Bundle contains 2 duplicate packages

Metrics (2 changes)
                 Current
Job #9680		      Baseline
Job #9678
Initial JS 267KiB(+0.06%) 266.85KiB
Initial CSS 37.07KiB 37.07KiB
Cache Invalidation 59.23% 0%
Chunks 3 3
Assets 4 4
Modules 526 526
Duplicate Modules 0 0
Duplicate Code 0% 0%
Packages 29 29
Duplicate Packages 1 1
Total size by type (1 change)
                 Current
Job #9680		      Baseline
Job #9678
CSS 37.07KiB 37.07KiB
Fonts 0B 0B
HTML 0B 0B
IMG 0B 0B
JS 267KiB (+0.06%) 266.85KiB
Media 0B 0B
Other 0B 0B

View job #9680 report View refactor-baselines branch activity

@vio vio force-pushed the refactor-baselines branch 2 times, most recently from 02aff74 to 6fdbd49 Compare September 25, 2023 17:32
@vio vio force-pushed the refactor-baselines branch from 6fdbd49 to e7948e0 Compare September 25, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vio