fix(CachingMappingFactory): Cache result in memory.

rekalogika · Jan 14, 2024 · 8ff3a84 · 8ff3a84
1 parent c6e09a1
commit 8ff3a84
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@
 * fix: Wrong service id for `CopyTransformer`.
 * fix: Remove cache file & regenerate it if it is corrupt.
 * fix: `NullTransformer` bug.
+* fix(`CachingMappingFactory`): Cache result in memory.
 
 ## 0.5.8
 

diff --git a/src/Mapping/CachingMappingFactory.php b/src/Mapping/CachingMappingFactory.php
@@ -21,7 +21,7 @@ final class CachingMappingFactory implements
     MappingFactoryInterface,
     CacheWarmerInterface
 {
-    private ?Mapping $innerMappingCache = null;
+    private ?Mapping $mapping = null;
 
     public function __construct(
         private MappingFactoryInterface $realMappingFactory,
@@ -31,11 +31,7 @@ public function __construct(
 
     private function getMappingFromInnerFactory(): Mapping
     {
-        if ($this->innerMappingCache === null) {
-            $this->innerMappingCache = $this->realMappingFactory->getMapping();
-        }
-
-        return $this->innerMappingCache;
+        return $this->realMappingFactory->getMapping();
     }
 
     private function warmUpAndGetMapping(): Mapping
@@ -47,8 +43,12 @@ private function warmUpAndGetMapping(): Mapping
 
     public function getMapping(): Mapping
     {
+        if ($this->mapping !== null) {
+            return $this->mapping;
+        }
+
         if (!file_exists($this->getCacheFilePath())) {
-            return $this->warmUpAndGetMapping();
+            return $this->mapping = $this->warmUpAndGetMapping();
         }
 
         try {
@@ -57,16 +57,16 @@ public function getMapping(): Mapping
         } catch (\Throwable) {
             unlink($this->getCacheFilePath());
 
-            return $this->warmUpAndGetMapping();
+            return $this->mapping = $this->warmUpAndGetMapping();
         }
 
         if (!$result instanceof Mapping) {
             unlink($this->getCacheFilePath());
 
-            return $this->warmUpAndGetMapping();
+            return $this->mapping = $this->warmUpAndGetMapping();
         }
 
-        return $result;
+        return $this->mapping = $result;
     }
 
     public function isOptional(): bool